Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔇 Remove lower batch size experiment #1645

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Jul 19, 2022

Motivation

The lower batch size experiment does not lend expected results. We still got lots of sendBeacon collisions before unload and at visibility change. Lets clear the code related to the experimentation.

Changes

  • Removes lower batch size
  • Removes failed sendBeacon telemetry

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque marked this pull request as ready for review July 19, 2022 09:51
@amortemousque amortemousque requested review from a team as code owners July 19, 2022 09:51
@codecov-commenter
Copy link

Codecov Report

Merging #1645 (6607f87) into main (97a51c6) will decrease coverage by 0.00%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #1645      +/-   ##
==========================================
- Coverage   90.86%   90.85%   -0.01%     
==========================================
  Files         129      128       -1     
  Lines        4686     4660      -26     
  Branches     1050     1042       -8     
==========================================
- Hits         4258     4234      -24     
+ Misses        428      426       -2     
Impacted Files Coverage Δ
...ges/core/src/domain/configuration/configuration.ts 100.00% <ø> (ø)
packages/rum-core/src/boot/startRum.ts 27.02% <ø> (+0.71%) ⬆️
packages/core/src/transport/batch.ts 90.47% <71.42%> (ø)
packages/core/src/transport/httpRequest.ts 100.00% <100.00%> (ø)
packages/rum/src/boot/startRecording.ts 100.00% <100.00%> (+4.54%) ⬆️
...ckages/rum/src/domain/segmentCollection/segment.ts 97.14% <100.00%> (-0.16%) ⬇️
.../src/domain/segmentCollection/segmentCollection.ts 100.00% <100.00%> (ø)
packages/rum/src/transport/send.ts 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@amortemousque amortemousque merged commit 798f75f into main Jul 20, 2022
@amortemousque amortemousque deleted the aymeric/remove-lower-batch-size-experiment branch July 20, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants