🐛 fix compatibility check #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously removed node_modules without reinstalling, so the parent TS version was used instead of the test/app one. By installing test/app dependencies, we make sure the correct version of TS is installed.
* the sed command worked on Mac but not on Linux 😮 * adding `--dev` removes a yarn warning from the output
BenoitZugmeyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We previously removed node_modules without reinstalling, so the parent TS version was used instead of the test/app one. By installing test/app dependencies, we make sure the correct version of TS is installed. Note: compatibility errors were caught by our ssr compatibility check
A sed command worked on Mac but not on Linux, so we didn't test for
exactOptionalPropertyTypescompatibility on CIChanges
Testing
I have gone over the contributing documentation.