-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚗️[RUMF-1351] experiment request retry strategy #1700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
force-pushed
the
bcaudan/implement-retry
branch
4 times, most recently
from
August 26, 2022 15:35
55d276b
to
f4bdb08
Compare
bcaudan
force-pushed
the
bcaudan/implement-retry
branch
from
August 29, 2022 15:44
f4bdb08
to
4e28db2
Compare
bcaudan
force-pushed
the
bcaudan/implement-retry
branch
from
August 29, 2022 16:05
989d790
to
82c719f
Compare
liywjl
reviewed
Aug 30, 2022
bcaudan
commented
Aug 30, 2022
liywjl
reviewed
Aug 30, 2022
liywjl
approved these changes
Aug 30, 2022
Codecov Report
@@ Coverage Diff @@
## main #1700 +/- ##
==========================================
+ Coverage 90.87% 90.97% +0.10%
==========================================
Files 128 129 +1
Lines 4812 4911 +99
Branches 1071 1089 +18
==========================================
+ Hits 4373 4468 +95
- Misses 439 443 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenoitZugmeyer
approved these changes
Aug 30, 2022
This was referenced Sep 5, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to improve our data transfer to:
Changes
Introduce new request strategy allowing us to:
Behind
retry
flag, use this new strategy for logs/rum for non exit requests.Testing
I have gone over the contributing documentation.