🐛 [RUMF-1393] don't mask attributes used to create CSS selectors #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
force-pushed
the
benoit/heatmap--dont-mask-stable-attributes
branch
from
f92b57e to
463adc4
Compare
Codecov Report
@@ Coverage Diff @@
## main #1737 +/- ##
=======================================
Coverage 90.95% 90.95%
=======================================
Files 129 129
Lines 5030 5030
Branches 1128 1128
=======================================
Hits 4575 4575
Misses 455 455
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
liywjl
approved these changes
Sep 15, 2022
BenoitZugmeyer
force-pushed
the
benoit/heatmap--dont-mask-stable-attributes
branch
from
463adc4 to
090ddb4
Compare
bcaudan
reviewed
Sep 19, 2022
* Use `STABLE_ATTRIBUTES` constant instead of hardcoded attribute name * Rename custom action name attribute used in tests so it does not match a stable attribute
bcaudan
approved these changes
Oct 17, 2022
…mask-stable-attributes
BenoitZugmeyer
force-pushed
the
benoit/heatmap--dont-mask-stable-attributes
branch
from
c00e3b8 to
5b4c3c6
Compare
BenoitZugmeyer
deleted the
benoit/heatmap--dont-mask-stable-attributes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Same as #1721, but for other attributes used by CSS selectors.
Changes
Testing
I have gone over the contributing documentation.