Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[RUMF-1276] handle performance entry without toJSON #1751

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Sep 30, 2022

Motivation

fix issue raised by telemetry

Changes

remove useless toJSON call and checks

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

+ fix entry.toJSON not used
@codecov-commenter
Copy link

Codecov Report

Merging #1751 (454dae8) into main (02d5b25) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1751      +/-   ##
==========================================
+ Coverage   91.03%   91.05%   +0.01%     
==========================================
  Files         128      128              
  Lines        4985     4984       -1     
  Branches     1113     1113              
==========================================
  Hits         4538     4538              
+ Misses        447      446       -1     
Impacted Files Coverage Δ
...rumEventsCollection/resource/resourceCollection.ts 100.00% <100.00%> (+2.12%) ⬆️
packages/core/src/transport/batch.ts 93.02% <0.00%> (-1.17%) ⬇️
packages/core/src/tools/timeUtils.ts 100.00% <0.00%> (+2.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan marked this pull request as ready for review September 30, 2022 13:21
@bcaudan bcaudan requested a review from a team as a code owner September 30, 2022 13:21
@bcaudan bcaudan merged commit a05153d into main Oct 3, 2022
@bcaudan bcaudan deleted the bcaudan/telemetry branch October 3, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants