⚗️[RUMF-1405] add mechanism to simulate intake issue #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1757 +/- ##
==========================================
- Coverage 91.05% 90.84% -0.22%
==========================================
Files 128 129 +1
Lines 4997 5024 +27
Branches 1118 1131 +13
==========================================
+ Hits 4550 4564 +14
- Misses 447 460 +13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bcaudan
force-pushed
the
bcaudan/simulate-intake-issue
branch
from
644b699 to
29fda3d
Compare
bcaudan
force-pushed
the
bcaudan/simulate-intake-issue
branch
from
29fda3d to
f660581
Compare
liywjl
approved these changes
Oct 4, 2022
|
The mechanism looks good. Maybe you could add some tests to check that replica calls aren't sent when the simulation is active. |
4 tasks
BenoitZugmeyer
added a commit
that referenced
this pull request
Dec 21, 2022
It turns out that the View `_dd.document_version` is replaced by another unrelated version in the backend. I wanted to duplicate this field so we can keep the original in views. Because unknown `_dd` fields are discarded from View events by the backend, I chose to put it in the global context, similarly to #1757 (and other before).
BenoitZugmeyer
added a commit
that referenced
this pull request
Jan 3, 2023
* 🔊 add view document_count in non-view events This will help investigate why view event counts are often incorrect. * 🐛 move document_version to global context It turns out that the View `_dd.document_version` is replaced by another unrelated version in the backend. I wanted to duplicate this field so we can keep the original in views. Because unknown `_dd` fields are discarded from View events by the backend, I chose to put it in the global context, similarly to #1757 (and other before). * 👌 put the documentVersion in view created event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Analyze behavior of retry strategy during intake issue
Changes
Testing
I have gone over the contributing documentation.