📝 Clarify log SDK usage in the readme #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liywjl
approved these changes
Oct 13, 2022
bcaudan
reviewed
Oct 13, 2022
amortemousque
force-pushed
the
aymeric/clarify-log-readme
branch
from
0361765 to
1b3d51c
Compare
amortemousque
force-pushed
the
aymeric/clarify-log-readme
branch
from
1b3d51c to
715718c
Compare
Codecov Report
@@ Coverage Diff @@
## main #1767 +/- ##
==========================================
+ Coverage 90.69% 90.71% +0.01%
==========================================
Files 130 130
Lines 5049 5049
Branches 1140 1140
==========================================
+ Hits 4579 4580 +1
+ Misses 470 469 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bcaudan
approved these changes
Oct 13, 2022
buraizu
requested changes
Oct 13, 2022
buraizu
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up of the issue #1764.
Clarify log SDK usage in the readme
Changes
Remove the mention of
other Javascript clientsin the readmeTesting
I have gone over the contributing documentation.