Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUMF-1377] Enable new request strategy #1770

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Oct 14, 2022

Motivation

We want to improve our data transfer to:

  • limit our impact on end user bandwidth
  • not loose data in case of short intake unavailability

Changes

Enable new request strategy for logs/rum for non exit requests allowing us to:

  • limit the number of concurrent requests to the intake -> max 32 by product
  • limit the total ongoing bytes of requests to the intake -> max 80kb by product
  • retry requests if the intake is momentarily unavailable -> exponential backoff strategy 1s to 60s
  • limit the size of queued requests due to throttling or failure -> max 3Mb by product

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner October 14, 2022 15:34
Base automatically changed from bcaudan/cleanup-simulation to main October 20, 2022 07:41
@bcaudan bcaudan requested a review from a team as a code owner October 20, 2022 07:41
@bcaudan bcaudan force-pushed the bcaudan/enable-retry-strategy branch from b81ea58 to c79f903 Compare October 20, 2022 07:45
@codecov-commenter
Copy link

Codecov Report

Merging #1770 (c79f903) into main (17d5f96) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
- Coverage   90.93%   90.93%   -0.01%     
==========================================
  Files         129      129              
  Lines        5022     5020       -2     
  Branches     1127     1126       -1     
==========================================
- Hits         4567     4565       -2     
  Misses        455      455              
Impacted Files Coverage Δ
packages/core/src/transport/httpRequest.ts 97.77% <100.00%> (+4.16%) ⬆️
packages/core/src/tools/timeUtils.ts 97.43% <0.00%> (-2.57%) ⬇️
packages/core/src/transport/batch.ts 93.02% <0.00%> (-1.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan force-pushed the bcaudan/enable-retry-strategy branch from d7566f5 to 38e0a9d Compare October 21, 2022 10:06
@bcaudan bcaudan enabled auto-merge (squash) October 21, 2022 10:10
@bcaudan bcaudan disabled auto-merge October 21, 2022 10:12
@bcaudan bcaudan merged commit 9093565 into main Oct 21, 2022
@bcaudan bcaudan deleted the bcaudan/enable-retry-strategy branch October 21, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants