Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔉[RUMF-1423] Add debug log for retry issue #1790

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Oct 25, 2022

Motivation

A couple of orgs generated some telemetry errors where payload is undefined in:

const payload = state.queuedPayloads.first()
send(payload, state, sendStrategy, {

Changes

  • add some debug info when the first payload of the queue is not defined
  • remove unnecessary resume after transport down debug log

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner October 25, 2022 09:49
@codecov-commenter
Copy link

Codecov Report

Merging #1790 (81caf70) into main (34223e3) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1790      +/-   ##
==========================================
- Coverage   90.99%   90.94%   -0.05%     
==========================================
  Files         129      129              
  Lines        5039     5038       -1     
  Branches     1133     1133              
==========================================
- Hits         4585     4582       -3     
- Misses        454      456       +2     
Impacted Files Coverage Δ
...ckages/core/src/transport/sendWithRetryStrategy.ts 98.83% <50.00%> (-1.17%) ⬇️
packages/core/src/transport/batch.ts 93.02% <0.00%> (-1.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants