REPLAY-1075: Resolve relative URLS to absolute in stylesheets #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liywjl
approved these changes
Oct 25, 2022
BenoitZugmeyer
approved these changes
Oct 26, 2022
bcaudan
reviewed
Oct 26, 2022
bcaudan
reviewed
Oct 27, 2022
bcaudan
approved these changes
Oct 27, 2022
N-Boutaib
deleted the
najib.boutaib/REPLAY-1075-keep-remote-css-href-attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve relative urls to absolute in CSS Style Sheets in order to properly fetch resource by the player
Changes
Extracting cssRules from a style sheet and converting them to text, switch absolute urls to relative ones based on the attribute href of the style sheet.
Testing
I have gone over the contributing documentation.