Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📈[RUMF-1432] Collect trackResources and trackLongTasks configs #1814

Merged

Conversation

liywjl
Copy link
Contributor

@liywjl liywjl commented Nov 8, 2022

Motivation

Collect trackResources and trackLongTasks

Changes

  • add trackResources and trackLongTasks to serializeConfiguration

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@liywjl liywjl requested a review from a team as a code owner November 8, 2022 17:03
@codecov-commenter
Copy link

Codecov Report

Merging #1814 (26252f6) into main (0ab07cb) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1814      +/-   ##
==========================================
- Coverage   93.23%   93.17%   -0.06%     
==========================================
  Files         131      131              
  Lines        5071     5071              
  Branches     1136     1136              
==========================================
- Hits         4728     4725       -3     
- Misses        343      346       +3     
Impacted Files Coverage Δ
...ges/core/src/domain/configuration/configuration.ts 91.17% <ø> (ø)
...rum-core/src/domain/contexts/foregroundContexts.ts 90.76% <0.00%> (-6.16%) ⬇️
packages/core/src/tools/timeUtils.ts 100.00% <0.00%> (+2.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liywjl liywjl requested a review from a team as a code owner November 14, 2022 15:42
@liywjl liywjl merged commit 7842e12 into main Nov 15, 2022
@liywjl liywjl deleted the william/collect-trackResources-and-trackLongTasks-configs branch November 15, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants