Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve event description message in developer extension #1831

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

amortemousque
Copy link
Contributor

Motivation

Improve the event description in the event list of the developer extension

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner November 18, 2022 16:40
@amortemousque amortemousque force-pushed the aymeric/improve-dev-ext-event-description branch from 1d90287 to bcc2c34 Compare November 18, 2022 16:43
@amortemousque amortemousque changed the title Improve event description message Improve event description message in developer extension Nov 18, 2022
Copy link
Contributor

@liywjl liywjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor change to avoid nested turnaries

developer-extension/src/panel/components/eventsTab.tsx Outdated Show resolved Hide resolved
@amortemousque amortemousque force-pushed the aymeric/improve-dev-ext-event-description branch from 8154b7e to 5cd7516 Compare November 25, 2022 16:37
@codecov-commenter
Copy link

Codecov Report

Merging #1831 (5cd7516) into main (6a581aa) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1831      +/-   ##
==========================================
- Coverage   93.11%   93.03%   -0.08%     
==========================================
  Files         131      131              
  Lines        5081     5081              
  Branches     1138     1138              
==========================================
- Hits         4731     4727       -4     
- Misses        350      354       +4     
Impacted Files Coverage Δ
...rum-core/src/domain/contexts/foregroundContexts.ts 90.76% <0.00%> (-6.16%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amortemousque amortemousque merged commit 73a0bb7 into main Nov 25, 2022
@amortemousque amortemousque deleted the aymeric/improve-dev-ext-event-description branch November 25, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants