Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-1449] fix Zone support when __symbol__ is missing #1872

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Dec 13, 2022

Motivation

We observed that some website define a Zone global variable unrelated to Zone.js, and this variable doesn't have a __symbol__ method, so it crashes the SDK.

Related: angular/zone.js#434

Changes

Check for the __symbol__ method before using it.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner December 13, 2022 13:57
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/fix-zonejs-support branch from e324fae to 2dc5881 Compare December 13, 2022 13:58
@codecov-commenter
Copy link

Codecov Report

Merging #1872 (2dc5881) into main (d1b1a42) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1872      +/-   ##
==========================================
- Coverage   93.20%   93.12%   -0.08%     
==========================================
  Files         137      137              
  Lines        5165     5165              
  Branches     1153     1153              
==========================================
- Hits         4814     4810       -4     
- Misses        351      355       +4     
Impacted Files Coverage Δ
packages/core/src/tools/getZoneJsOriginalValue.ts 100.00% <100.00%> (ø)
...rum-core/src/domain/contexts/foregroundContexts.ts 90.76% <0.00%> (-6.16%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BenoitZugmeyer BenoitZugmeyer merged commit b67b0c1 into main Dec 13, 2022
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/fix-zonejs-support branch December 13, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants