Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[RUMF-1435] don't retry opaque response #1877

Merged
merged 4 commits into from
Dec 15, 2022
Merged

🐛[RUMF-1435] don't retry opaque response #1877

merged 4 commits into from
Dec 15, 2022

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Dec 14, 2022

Motivation

If the browser somehow consider the intake response as opaque, we won't be able to access its true status and may wrongly retry it.

Changes

  • do not retry opaque response
  • force request mode 'cors'
  • add extra debug tag with response type

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan marked this pull request as ready for review December 14, 2022 13:23
@bcaudan bcaudan requested a review from a team as a code owner December 14, 2022 13:23
Co-authored-by: Benoît <benoit.zugmeyer@datadoghq.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1877 (c45cc0f) into main (e5c2966) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
+ Coverage   93.12%   93.20%   +0.08%     
==========================================
  Files         137      137              
  Lines        5165     5168       +3     
  Branches     1153     1155       +2     
==========================================
+ Hits         4810     4817       +7     
+ Misses        355      351       -4     
Impacted Files Coverage Δ
...s/core/src/domain/configuration/endpointBuilder.ts 100.00% <100.00%> (ø)
packages/core/src/transport/httpRequest.ts 97.95% <100.00%> (ø)
...ckages/core/src/transport/sendWithRetryStrategy.ts 100.00% <100.00%> (ø)
...rum-core/src/domain/contexts/foregroundContexts.ts 96.92% <0.00%> (+6.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan merged commit e2b75c4 into main Dec 15, 2022
@bcaudan bcaudan deleted the bcaudan/opaque branch December 15, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants