Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [RUMF-1435] do not retry status 0 request while online #1891

Merged
merged 2 commits into from
Dec 20, 2022
Merged

🐛 [RUMF-1435] do not retry status 0 request while online #1891

merged 2 commits into from
Dec 20, 2022

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Dec 20, 2022 •
edited
Loading

Motivation

Some intake requests are retried due to response status 0 while the data still reach datadog.

Changes

  • Retry request when status is 0 only when offline
  • Remove retry_after_type debug tag

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan marked this pull request as ready for review December 20, 2022 08:39
@bcaudan bcaudan requested a review from a team as a code owner December 20, 2022 08:39
@bcaudan bcaudan merged commit 12df888 into main Dec 20, 2022
@bcaudan bcaudan deleted the bcaudan/retry-offline branch December 20, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amortemousque amortemousque amortemousque approved these changes

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcaudan @BenoitZugmeyer @amortemousque