Fix getInitConfiguration()
behaviour
#1893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Context: Synthetics Profiler doesn't tag profiles with correct service tag
I need
DD_RUM.getInitConfiguration()
to return init configuration even if it's inside synthetic test. Currently, when I callDD_RUM.getInitConfiguration()
inside synthetic test, it returns undefined, becauseinitRum()
function is interrupted by:which prevents from this code to be executed:
This breaks profile tagging, as we can't infer service name (and because of that, we can't resolve source maps)
I think that
getInitConfiguration()
should return init configuration even if init process was not successful (as this function is not calledgetValidInitConfiguration()
orgetInitConfigurationIfInitWasSuccessful()
)Changes
Update RUM and Logs API -
getInitConfiguration()
will return init configuration regardless of init process outcome.Testing
I have gone over the contributing documentation.