⚗🐛 reset input state at the beginning of each click

packages/rum-core/src/domain/rumEventsCollection/action/listenActionEvents.spec.ts

@@ -1,3 +1,4 @@
+import { resetExperimentalFeatures, updateExperimentalFeatures } from '@datadog/browser-core'
 import type { Clock } from '../../../../../core/test/specHelper'
 import { createNewEvent, mockClock } from '../../../../../core/test/specHelper'
 import type { ActionEventsHooks } from './listenActionEvents'
@@ -180,10 +181,30 @@ describe('listenActionEvents', () => {
     it('click that triggers an input event slightly after the click should report an input user activity', () => {
       emulateClick()
       emulateInputEvent()
-      clock.tick(1)
+      clock.tick(1) // run immediate timeouts
       expect(hasInputUserActivity()).toBe(true)
     })
 
+    describe('with fix_dead_clicks_after_input flag', () => {
+      beforeEach(() => {
+        stopListenEvents()
+
+        updateExperimentalFeatures(['fix_dead_clicks_after_input'])
+        ;({ stop: stopListenEvents } = listenActionEvents(actionEventsHooks))
+      })
+
+      afterEach(() => {
+        resetExperimentalFeatures()
+      })
+
+      it('input events that precede clicks should not be taken into account', () => {
+        emulateInputEvent()
+        emulateClick()
+        clock.tick(1) // run immediate timeouts
+        expect(hasInputUserActivity()).toBe(false)
+      })
+    })
+
     it('click and type should report an input user activity', () => {
       emulateClick({
         beforeMouseUp() {

packages/rum-core/src/domain/rumEventsCollection/action/listenActionEvents.ts

@@ -1,4 +1,4 @@
-import { addEventListener, DOM_EVENT, monitor } from '@datadog/browser-core'
+import { addEventListener, DOM_EVENT, isExperimentalFeatureEnabled, monitor } from '@datadog/browser-core'
 
 export type MouseEventOnElement = MouseEvent & { target: Element }
 
@@ -21,6 +21,9 @@ export function listenActionEvents<ClickContext>({ onPointerDown, onClick }: Act
       (event) => {
         hasSelectionChanged = false
         selectionEmptyAtPointerDown = isSelectionEmpty()
+        if (isExperimentalFeatureEnabled('fix_dead_clicks_after_input')) {
+          hasInputChanged = false
+        }
         if (isMouseEventOnElement(event)) {
           clickContext = onPointerDown(event)
         }