-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 ♻️ [RUMF 1470] Fix serialization issues #1971
Merged
yannickadam
merged 12 commits into
main
from
yannick.adam/rumf-1470-serialization-issues
Mar 27, 2023
Merged
🐛 ♻️ [RUMF 1470] Fix serialization issues #1971
yannickadam
merged 12 commits into
main
from
yannick.adam/rumf-1470-serialization-issues
Mar 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickadam
force-pushed
the
yannick.adam/rumf-1470-serialization-issues
branch
from
January 25, 2023 21:37
c48716a
to
bbda59d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1971 +/- ##
==========================================
+ Coverage 93.50% 93.51% +0.01%
==========================================
Files 159 160 +1
Lines 5496 5586 +90
Branches 1254 1293 +39
==========================================
+ Hits 5139 5224 +85
- Misses 357 362 +5
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yannickadam
force-pushed
the
yannick.adam/rumf-1470-serialization-issues
branch
9 times, most recently
from
February 1, 2023 15:11
a422583
to
317c169
Compare
yannickadam
force-pushed
the
yannick.adam/rumf-1470-serialization-issues
branch
from
February 2, 2023 16:53
317c169
to
28dd61b
Compare
bcaudan
reviewed
Feb 7, 2023
yannickadam
force-pushed
the
yannick.adam/rumf-1470-serialization-issues
branch
from
February 24, 2023 09:28
f37c1f2
to
d3c0cba
Compare
yannickadam
force-pushed
the
yannick.adam/rumf-1470-serialization-issues
branch
from
February 24, 2023 09:54
d3c0cba
to
7d05660
Compare
bcaudan
reviewed
Feb 27, 2023
bcaudan
reviewed
Feb 27, 2023
bcaudan
reviewed
Feb 27, 2023
bcaudan
reviewed
Mar 3, 2023
bcaudan
approved these changes
Mar 7, 2023
bcaudan
approved these changes
Mar 7, 2023
BenoitZugmeyer
approved these changes
Mar 7, 2023
amortemousque
approved these changes
Mar 23, 2023
yannickadam
force-pushed
the
yannick.adam/rumf-1470-serialization-issues
branch
from
March 23, 2023 09:24
0e70d96
to
d84f9ae
Compare
bcaudan
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We sometimes experience issues while serializing user-provided data:
Changes
This PR introduces a function named
sanitize
that is meant to be called each time user-provided data is ingested.In it's current form, it should be minimally invasive to be merged into a minor release.
Later - We can introduce better/more relevant serialization for specific types which will introduce breaking changes.
Testing
I have gone over the contributing documentation.