✅ fix Jasmine deprecation warning in unit tests/IE #1974
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
"DEPRECATION: describe with no children (describe() or it()) is deprecated and will be removed in a future version of Jasmine."
Changes
Wrapping the
describe
in aif
statement is not really pretty. Ideally we would use "shadow dom" APIs insidebeforeEach
orit
blocks instead ofdescribe
, but this prevents us from using a list to generate test cases.I think it's acceptable until we eventually drop IE support.
Testing
I have gone over the contributing documentation.