-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
βπ [RUMF-1293] discard dead clicks when activity occurs on pointerdown #1979
Merged
BenoitZugmeyer
merged 1 commit into
main
from
benoit/frustration-signals--track-pointerdown-activity
Jan 30, 2023
Merged
βπ [RUMF-1293] discard dead clicks when activity occurs on pointerdown #1979
BenoitZugmeyer
merged 1 commit into
main
from
benoit/frustration-signals--track-pointerdown-activity
Jan 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2023
BenoitZugmeyer
force-pushed
the
benoit/frustration-signals--track-pointerdown-activity
branch
2 times, most recently
from
January 27, 2023 14:58
95dc3e5
to
b5e1da4
Compare
bcaudan
reviewed
Jan 30, 2023
packages/rum-core/src/domain/rumEventsCollection/action/trackClickActions.ts
Show resolved
Hide resolved
bcaudan
approved these changes
Jan 30, 2023
BenoitZugmeyer
force-pushed
the
benoit/frustration-signals--track-pointerdown-activity
branch
from
January 30, 2023 13:15
8dfe8ec
to
b5e1da4
Compare
Base automatically changed from
benoit/frustration-signals--track-pointerup
to
main
January 30, 2023 13:56
BenoitZugmeyer
force-pushed
the
benoit/frustration-signals--track-pointerdown-activity
branch
from
January 30, 2023 14:00
b5e1da4
to
28207e3
Compare
BenoitZugmeyer
deleted the
benoit/frustration-signals--track-pointerdown-activity
branch
January 30, 2023 14:43
4 tasks
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 6, 2023
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 6, 2023
4 tasks
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 7, 2023
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 7, 2023
pm_trace_id: 13144861 feature_branch_pipeline_id: 13144861 source: to-staging * commit '6a98a9480c800aff92ce4c5d37270534623f7661': β remove now unneeded experimental flag from e2e tests β π₯ remove now unneeded clock mock in tests π©π enable fix #1979 π remove pointerup_delay info for #1958 π©π enable fix #1958 π©π enable fix #1968 π©π enable fix #1986
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 10, 2023
* π©π enable fix #1986 * π©π enable fix #1968 * π©π enable fix #1958 * π remove pointerup_delay info for #1958 * π©π enable fix #1979 * β π₯ remove now unneeded clock mock in tests * β remove now unneeded experimental flag from e2e tests * π rename `onStartEvent` to `onPointerUp` * π rename startEvent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket is part of an effort to improve dead clicks.
All three fixes are behind the
dead_click_fixes
and will be released together after some dogfooding.Motivation
We observed that in some cases, click actions are flagged as "dead click" when the UI updates during "pointerdown" or "mousedown" events (happening before the "click" event).
Changes
With this PR, we'll observe page activity occuring during the "pointerdown" event, and will discard the "dead click" frustration if some activity occurs.
Testing
I have gone over the contributing documentation.