✅ fix flaky test #1982
Merged
✅ fix flaky test #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
approved these changes
Jan 30, 2023
FMU, this test was assuming that `Promise.resolve` took less than 1ms. But this was often failing, and the `setTimeout` callback was called too often. By using `collectAsyncCalls`, we remove this race condition.
BenoitZugmeyer
force-pushed
the
benoit/fix-flaky-test
branch
from
6947338 to
9389e33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This particular test is quite flaky.
FMU, it was assuming that
Promise.resolvetook less than 1ms. But this was often not the case, and thesetTimeoutcallback was called too often.Changes
By using
collectAsyncCalls, we remove this race condition.Testing
I have gone over the contributing documentation.