🐛 fix frustration animation in session replay #1999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
==========================================
- Coverage 93.50% 93.49% -0.02%
==========================================
Files 145 145
Lines 5515 5515
Branches 1258 1258
==========================================
- Hits 5157 5156 -1
- Misses 358 359 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Frustration records used to reference MouseInteraction/Click records. Since Click Actions are now generated based on mouseup events, we broke this reference. There is no MouseInteraction/PointerUp record that Frustration can reference. This commit is a quick fix. It changes how we are generating MouseInteraction/MouseUp records: instead of listening to mouseup DOM events, we now listen to pointerup events, allowing Frustration records to reference MouseInteraction/MouseUp records. This works on the player side without any modification. In the context of supporting Mobile Session Replay, we introduced `PointerInteraction` records used by the Mobile SDKs in place of `MouseInteraction`. In the future, it would be great to replace `MouseInteraction` by `PointerInteraction` in the Browser SDK so we have an uniform way to convey such interaction. This would cleanly solve the issue since we would have `PointerInteraction/Up` records that we could reference from `Frustration` records.
BenoitZugmeyer
force-pushed
the
benoit/frustration-signals--fix-replay-frustration-animation
branch
from
92794a8 to
864ff6c
Compare
N-Boutaib
approved these changes
Feb 6, 2023
yannickadam
approved these changes
Feb 7, 2023
BenoitZugmeyer
deleted the
benoit/frustration-signals--fix-replay-frustration-animation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Frustration records used to reference MouseInteraction/Click records. Since Click Actions are now generated based on mouseup events, we broke this reference. There is no MouseInteraction/PointerUp record that Frustration can reference.
Changes
This commit is a quick fix. It changes how we are generating MouseInteraction/MouseUp records: instead of listening to mouseup DOM events, we now listen to pointerup events, allowing Frustration records to reference MouseInteraction/MouseUp records.
This works on the player side without any modification.
In the context of supporting Mobile Session Replay, we introduced
PointerInteractionrecords used by the Mobile SDKs in place ofMouseInteraction. In the future, it would be great to replaceMouseInteractionbyPointerInteractionin the Browser SDK so we have an uniform way to convey such interaction. This would cleanly solve the issue since we would havePointerInteraction/Uprecords that we could reference fromFrustrationrecords.Testing
I have gone over the contributing documentation.