🐛[RUMF-1493] Avoid infinite loop on form > input[name="host"] element
#2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to not count form element with child input as name host as a shadow root
ThibautGeriz
changed the title
ThibautGeriz
commented
Feb 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #2017 +/- ##
==========================================
+ Coverage 93.49% 93.58% +0.09%
==========================================
Files 145 145
Lines 5507 5507
Branches 1249 1249
==========================================
+ Hits 5149 5154 +5
+ Misses 358 353 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ThibautGeriz
changed the title
bcaudan
reviewed
Feb 15, 2023
ThibautGeriz
changed the title
form > input[name="host"] element
ThibautGeriz
force-pushed
the
thibaut.gery/fix-freeze
branch
from
61bdbbd to
f5f570e
Compare
ThibautGeriz
force-pushed
the
thibaut.gery/fix-freeze
branch
from
f5f570e to
6f74f0d
Compare
bcaudan
approved these changes
Feb 15, 2023
Co-authored-by: Bastien Caudan <1331991+bcaudan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix freeze in serialization because of infinite loop
Changes
Make sure to not count form element with child input as name host as a shadow root
Testing
I have gone over the contributing documentation.