RUMF-1497 Allow logger APIs to pass an Error parameter #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickadam
force-pushed
the
yannick.adam/RUMF-1497-Enhance-logger-error-api
branch
from
a658e3e to
2d5faf2
Compare
packages/logs/src/domain/logsCollection/console/consoleCollection.ts
Outdated
Show resolved
Hide resolved
bcaudan
reviewed
Feb 22, 2023
yannickadam
force-pushed
the
yannick.adam/RUMF-1497-Enhance-logger-error-api
branch
from
2d5faf2 to
6b6de63
Compare
yannickadam
changed the title
bcaudan
reviewed
Mar 9, 2023
Codecov Report
@@ Coverage Diff @@
## main #2029 +/- ##
==========================================
- Coverage 93.48% 93.42% -0.07%
==========================================
Files 145 145
Lines 5512 5522 +10
Branches 1250 1255 +5
==========================================
+ Hits 5153 5159 +6
- Misses 359 363 +4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bcaudan
approved these changes
Mar 10, 2023
amortemousque
approved these changes
Mar 10, 2023
BenoitZugmeyer
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The goal of this PR is to align capabilities for error monitoring between RUM and LOGS SDKs.
Changes
Added an optional error parameter:
logger.[level](message: string, messageContext?: object, error?: Error)which will be serialized as part of an error context, with defined fields (message, kind, stack)
I have gone over the contributing documentation.