Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️[RUMF-1517] split scripts utils #2102

Merged
merged 6 commits into from
Mar 28, 2023
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Mar 24, 2023

Motivation

Avoid single utils file

Changes

Split scripts/lib/utils.js in:

  • execution-utils.js
  • files-utils.js
  • git-utils.js
  • secrets.js

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan marked this pull request as ready for review March 24, 2023 13:35
@bcaudan bcaudan requested a review from a team as a code owner March 24, 2023 13:35
@codecov-commenter
Copy link

Codecov Report

Merging #2102 (73ac680) into main (0c11ac9) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2102      +/-   ##
==========================================
- Coverage   93.58%   93.55%   -0.04%     
==========================================
  Files         159      159              
  Lines        5506     5506              
  Branches     1259     1259              
==========================================
- Hits         5153     5151       -2     
- Misses        353      355       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan merged commit 63ad678 into main Mar 28, 2023
@bcaudan bcaudan deleted the bcaudan/split-script-utils branch March 28, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants