♻️ [RUMF-1529] use an enum for experimental features #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
force-pushed
the
benoit/stricter-feature-flags
branch
from
361fba3 to
22b1acf
Compare
Codecov Report
@@ Coverage Diff @@
## main #2113 +/- ##
==========================================
- Coverage 93.67% 93.48% -0.19%
==========================================
Files 163 163
Lines 5691 5711 +20
Branches 1303 1310 +7
==========================================
+ Hits 5331 5339 +8
- Misses 360 372 +12
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bcaudan
approved these changes
Mar 28, 2023
yannickadam
reviewed
Mar 28, 2023
|
|
||
| export function updateExperimentalFeatures(enabledFeatures: string[] | undefined): void { | ||
| export function updateExperimentalFeatures(enabledFeatures: ExperimentalFeature[] | undefined): void { |
There was a problem hiding this comment.
🥜 nitpick: This function cannot update (disable) a feature already present. Maybe we should name it addExperimentalFeatures ?
amortemousque
approved these changes
Mar 28, 2023
Let's define the `enabledExperimentalFeature` during module evaluation. This way, we don't need to worry about it being undefined. Also, we are now validating `enabledExperimentalFeature` configuration in `configuration.ts`, so move validation tests there.
bcaudan
reviewed
Mar 29, 2023
yannickadam
approved these changes
Mar 29, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve typecheck, helps to clean flags when enabling them.
Changes
Use an enum for experimental features
Testing
I have gone over the contributing documentation.