-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUMF-1510] Warn the user when a heavy context is used #2120
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2120 +/- ##
==========================================
- Coverage 93.62% 93.58% -0.04%
==========================================
Files 179 181 +2
Lines 5989 6003 +14
Branches 1344 1345 +1
==========================================
+ Hits 5607 5618 +11
- Misses 382 385 +3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2ee8991
to
570fcbb
Compare
570fcbb
to
15b2575
Compare
@@ -13,12 +13,19 @@ export const enum CustomerDataType { | |||
LoggerContext = 'logger context', | |||
} | |||
|
|||
let alreadyWarned: { [key: string]: boolean } = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question: FMU, for a npm setup with both logs and rum, it would mean that we would warn customers once for all SDK instances, is it intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it was not :)
I moved the "already warn check" to contextManager
and featureFlagContext
to solve it.
Let me know what you think.
96d3ba0
to
f5a2c54
Compare
Motivation
Raise awareness about customer data impact on the user bandwidth.
Changes
getGlobalObject
on its own file to avoid circular ref withtimer.ts
getGlobalObject
insetTimeout
andsetInterval
Testing
I have gone over the contributing documentation.