✅ improve async calls collection #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
* Do not wait for 300ms to check for extra calls * Simplify usage by asserting no extra calls are done automatically * Help debugging by printing the spec name when an asynchronous call is done after the spec finished.
BenoitZugmeyer
force-pushed
the
benoit/improve-async-calls-collection
branch
from
92a2139 to
ac44e59
Compare
Codecov Report
@@ Coverage Diff @@
## main #2123 +/- ##
==========================================
- Coverage 93.68% 93.56% -0.13%
==========================================
Files 178 179 +1
Lines 5974 5983 +9
Branches 1341 1342 +1
==========================================
+ Hits 5597 5598 +1
- Misses 377 385 +8
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The asynchronous call collection utility is a bit complex and suboptimal
as we wait 300ms for each test to check whether some calls are done
after the end of assertions.
Changes
Do not wait for 300ms to check for extra calls
Simplify usage by asserting no extra calls are done automatically
Help debugging by printing the spec name when an asynchronous call is
done after the spec finished.
This change reduces tests execution time by 5 seconds on my machine.
Before:
After:
Testing
I have gone over the contributing documentation.