-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛[RUMF-1544] Fix badly polyfilled URL #2141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
force-pushed
the
aymeric/keep-url-ref
branch
from
April 5, 2023 14:41
f6bd6ea
to
c35f0a3
Compare
amortemousque
force-pushed
the
aymeric/keep-url-ref
branch
from
April 5, 2023 14:42
c35f0a3
to
7f85aa9
Compare
Codecov Report
@@ Coverage Diff @@
## main #2141 +/- ##
==========================================
- Coverage 93.62% 93.47% -0.15%
==========================================
Files 192 192
Lines 6005 6009 +4
Branches 1345 1350 +5
==========================================
- Hits 5622 5617 -5
- Misses 383 392 +9
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yannickadam
approved these changes
Apr 5, 2023
bcaudan
approved these changes
Apr 6, 2023
BenoitZugmeyer
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It has been observed that on some customer website, URL is badly polyfilled. It might not be a constructor, and might not provide a URL.createObjectURL function.
Changes
checkURLSupported
bygetSupportedURL
to keep the original URL ref to avoid theURL is not a constructor
error in thebuildUrl
.URL.createObjectURL
is supported for the recorder to avoidURL.createObjectURL is not a function
error in the workerbuildURL
instead ofnew URL
. Inspired by no-new-symbol ruleTesting
I have gone over the contributing documentation.