Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧[e2e cbt] setup retry #218

Merged
merged 4 commits into from
Dec 20, 2019
Merged

🔧[e2e cbt] setup retry #218

merged 4 commits into from
Dec 20, 2019

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Dec 20, 2019

No description provided.

- add extra messages for e2e cases
- add a delay between retries to handle case where other tests are already running
@bcaudan bcaudan requested a review from a team as a code owner December 20, 2019 10:32
scripts/cbt-with-retry.js Outdated Show resolved Hide resolved
const COMMAND = `${rootDirectory}/node_modules/.bin/karma start ${rootDirectory}/test/unit/karma.cbt.conf.js`
const [_, __, ...args] = process.argv
const COMMAND = `yarn ${args.join(' ')}`
const RETRY_DELAY_IN_MIN = 5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 minutes seems a bit much?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit takers 6-7 min, what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok it makes sense.

scripts/cbt-with-retry.js Outdated Show resolved Hide resolved
@bcaudan bcaudan merged commit c6bc7c6 into master Dec 20, 2019
@bcaudan bcaudan deleted the bcaudan/flaky-e2e-cbt branch December 20, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants