Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix isolatedModules support #2209

Merged
merged 2 commits into from
May 10, 2023

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented May 4, 2023

Motivation

Support TS projects using isolatedModules: true

This PR fixes #2208.

Bug reported here: microsoft/TypeScript#54152

Changes

  • add an integration test to make sure we are compatible with this option
  • use a workaround to fix the TS error

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner May 4, 2023 13:59
Copy link
Contributor

@yannickadam yannickadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While alternatives exists, they have impacts on the bundle size:
enum => ~ +1800 bytes
const object => ~ + 120 bytes
Since we do not consider that LifeCycleEventType needs to be exposed, this workaround seems to be the most appropriate for now.

@codecov-commenter
Copy link

Codecov Report

Merging #2209 (514fac0) into main (549b3e8) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2209      +/-   ##
==========================================
- Coverage   93.85%   93.83%   -0.02%     
==========================================
  Files         201      201              
  Lines        6082     6082              
  Branches     1347     1347              
==========================================
- Hits         5708     5707       -1     
- Misses        374      375       +1     
Impacted Files Coverage Δ
packages/rum-core/src/domain/lifeCycle.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BenoitZugmeyer BenoitZugmeyer merged commit aa9fb1e into main May 10, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/fix-isolated-modules-support branch May 10, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScripts changes causes build issues
4 participants