Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-1576] fix support for tools that removes console.* references #2210

Merged
merged 1 commit into from
May 9, 2023

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

When building JS bundles, some users might use a plugin or configuration to remove "console.*" references. This causes some issue as we expect console.* to be defined. As a workaround, let's use a variable alias, so those expressions won't be taken into account by simple static analysis.

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner May 5, 2023 13:22
@codecov-commenter
Copy link

Codecov Report

Merging #2210 (30f86aa) into main (549b3e8) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2210      +/-   ##
==========================================
- Coverage   93.85%   93.83%   -0.02%     
==========================================
  Files         201      201              
  Lines        6082     6083       +1     
  Branches     1347     1347              
==========================================
  Hits         5708     5708              
- Misses        374      375       +1     
Impacted Files Coverage Δ
...kages/core/src/domain/console/consoleObservable.ts 100.00% <100.00%> (ø)
packages/core/src/tools/display.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BenoitZugmeyer BenoitZugmeyer merged commit 179d8df into main May 9, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/dont-use-console-directly branch May 9, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants