-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [RUMF-1583][recorder] do not ignore empty text node during serialization #2237
🐛 [RUMF-1583][recorder] do not ignore empty text node during serialization #2237
Conversation
If we ignore empty text nodes during serialization, any 'characterData' mutation will be discarded because we wouldn't know about the corresponding serialized node.
/to-staging |
🚂 Branch Integration commit 382e3f8 will soon be integrated into staging-19. This build is going to start soon! (estimated merge in less than 7m) you can cancel this operation by commenting your pull request with |
🚂 Branch Integration commit 382e3f8 has been merged into staging-19 |
Codecov Report
@@ Coverage Diff @@
## main #2237 +/- ##
==========================================
- Coverage 94.09% 94.01% -0.09%
==========================================
Files 201 201
Lines 6083 6083
Branches 1347 1347
==========================================
- Hits 5724 5719 -5
- Misses 359 364 +5
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
packages/rum/src/domain/record/observers/mutationObserver.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Yannick Adam <yannick.adam@datadoghq.com>
/to-staging |
🚂 Branch Integration commit ffe804c will soon be integrated into staging-19. This build is going to start soon! (estimated merge in less than 7m) you can cancel this operation by commenting your pull request with |
🚂 Branch Integration commit ffe804c has been merged into staging-19 |
Motivation
If we ignore empty text nodes during serialization, any 'characterData' mutation will be discarded because we wouldn't know about the corresponding serialized node.
Changes
Don't ignore empty text nodes
Testing
I have gone over the contributing documentation.