Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 [RUM-232] fix worker/string package #2331

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

#2330

Changes

  • export cjs, esm and types for the /string package
  • unignore built files

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner July 11, 2023 08:04
@BenoitZugmeyer
Copy link
Member Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 11, 2023

🚂 Branch Integration: starting soon, merge in < 0s

commit 4a6e18df94 will soon be integrated into staging-28.

This build is going to start soon! (estimated merge in less than 0s)

you can cancel this operation by commenting your pull request with /to-staging -c!

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 11, 2023

🚂 Branch Integration: this commit was successfully integrated

commit 4a6e18df94 has been merged into staging-28 in merge commit 423668ddfb

packages/worker/string/package.json Outdated Show resolved Hide resolved
packages/worker/scripts/build-worker-string.js Outdated Show resolved Hide resolved
@BenoitZugmeyer
Copy link
Member Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 11, 2023

🚂 Branch Integration: starting soon, merge in < 8m

commit 5c2897bab1 will soon be integrated into staging-28.

This build is going to start soon! (estimated merge in less than 8m)

you can cancel this operation by commenting your pull request with /to-staging -c!

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 11, 2023

🚂 Branch Integration: this commit was successfully integrated

commit 5c2897bab1 has been merged into staging-28 in merge commit cc6e14f208

@BenoitZugmeyer BenoitZugmeyer merged commit 34fb2d8 into main Jul 11, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/fix-worker-package branch July 11, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants