Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Fix scope packages npm publication #2334

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

amortemousque
Copy link
Contributor

Motivation

When publishing for the first time a scope package, npm assumes the access is private by default and we end up the error
Package failed to publish. You must sign up for private packages.

Changes

Specify the publish access public in package.json for all published packages

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested review from a team as code owners July 11, 2023 10:34
@amortemousque amortemousque changed the title 👷 Fix publication scope package npm publication 👷 Fix scope packages npm publication Jul 11, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2334 (2a0f20f) into main (33c6330) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2334      +/-   ##
==========================================
- Coverage   94.20%   94.10%   -0.10%     
==========================================
  Files         206      206              
  Lines        6128     6128              
  Branches     1357     1357              
==========================================
- Hits         5773     5767       -6     
- Misses        355      361       +6     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amortemousque amortemousque merged commit c63e51f into main Jul 11, 2023
@amortemousque amortemousque deleted the aymeric/npm-public-package-publication branch July 11, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants