Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Avoid setting non-object values for contexts #2341

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Jul 17, 2023

Motivation

Telemetry errors Cannot convert undefined or null to object in rum assembly

Changes

If setXXXContext() is called with a non-object value, defaults context value to {}

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan
Copy link
Contributor Author

bcaudan commented Jul 17, 2023

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 17, 2023

🚂 Branch Integration: starting soon, merge in < 0s

commit 99f5c80ee9 will soon be integrated into staging-29.

This build is going to start soon! (estimated merge in less than 0s)

you can cancel this operation by commenting your pull request with /to-staging -c!

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 17, 2023

🚂 Branch Integration: this commit was successfully integrated

commit 99f5c80ee9 has been merged into staging-29 in merge commit f6e80bc921

@bcaudan bcaudan marked this pull request as ready for review July 17, 2023 08:32
@bcaudan bcaudan requested a review from a team as a code owner July 17, 2023 08:32
@bcaudan
Copy link
Contributor Author

bcaudan commented Jul 17, 2023

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 17, 2023

🚂 Branch Integration: starting soon, merge in < 8m

commit 3f75cc51b2 will soon be integrated into staging-29.

This build is going to start soon! (estimated merge in less than 8m)

you can cancel this operation by commenting your pull request with /to-staging -c!

@codecov-commenter
Copy link

Codecov Report

Merging #2341 (3f75cc5) into main (fa93f71) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2341   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files         206      206           
  Lines        6131     6134    +3     
  Branches     1357     1358    +1     
=======================================
+ Hits         5775     5778    +3     
  Misses        356      356           
Impacted Files Coverage Δ
...ges/core/src/tools/serialisation/contextManager.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 17, 2023

🚂 Branch Integration: this commit was successfully integrated

commit 3f75cc51b2 has been merged into staging-29 in merge commit 0b7f566a8c

@bcaudan bcaudan merged commit 6770d22 into main Jul 17, 2023
@bcaudan bcaudan deleted the bcaudan/context-error branch July 17, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants