-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Avoid setting non-object values for contexts #2341
Conversation
/to-staging |
🚂 Branch Integration: starting soon, merge in < 0s commit 99f5c80ee9 will soon be integrated into staging-29. This build is going to start soon! (estimated merge in less than 0s) you can cancel this operation by commenting your pull request with |
🚂 Branch Integration: this commit was successfully integrated commit 99f5c80ee9 has been merged into staging-29 in merge commit f6e80bc921 |
/to-staging |
🚂 Branch Integration: starting soon, merge in < 8m commit 3f75cc51b2 will soon be integrated into staging-29. This build is going to start soon! (estimated merge in less than 8m) you can cancel this operation by commenting your pull request with |
Codecov Report
@@ Coverage Diff @@
## main #2341 +/- ##
=======================================
Coverage 94.19% 94.19%
=======================================
Files 206 206
Lines 6131 6134 +3
Branches 1357 1358 +1
=======================================
+ Hits 5775 5778 +3
Misses 356 356
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
🚂 Branch Integration: this commit was successfully integrated commit 3f75cc51b2 has been merged into staging-29 in merge commit 0b7f566a8c |
Motivation
Telemetry errors
Cannot convert undefined or null to object
in rum assemblyChanges
If
setXXXContext()
is called with a non-object value, defaults context value to{}
Testing
I have gone over the contributing documentation.