-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔈Add web vital attribution telemetry debug #2344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add recorderStartObservable - Expose getSerializedNodeId
bcaudan
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #2344 +/- ##
==========================================
- Coverage 94.17% 93.99% -0.19%
==========================================
Files 206 208 +2
Lines 6134 6175 +41
Branches 1358 1368 +10
==========================================
+ Hits 5777 5804 +27
- Misses 357 371 +14
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
amortemousque
force-pushed
the
aymeric/debug-selector-match-nodeid
branch
from
July 19, 2023 15:31
ad296c9
to
c027125
Compare
amortemousque
force-pushed
the
aymeric/debug-selector-match-nodeid
branch
from
July 19, 2023 19:34
2d9d55c
to
8f13844
Compare
BenoitZugmeyer
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Assess the best strategy to display / collect the Core Web Vital attributed node.
Here are the questions that need to be answered:
Answered with the "XXX attribution" telemetry debug:
hasNode
: Check if the web vital has an attributed element to collectreplayRecording
: is Replay recordingserializedDomNode
: Get the serialized DOM node if availablecomputationDelay
: Delay between the web vital and the collection of the web vital by the SDKAnswered with the "XXX attribution recording delay" debug:
recordingDelay
: Delay between the web vital and Replay startcomputationDelay
: Delay between the web vital and the collection of the web vital by the SDKhasNode
: Do we still have the node when replay startsserializedDomNode
: Can we still get the Node id when replay startsChanges
Testing
I have gone over the contributing documentation.