Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM][REPLAY] Try to reduce the size of the replay payload #2348

Merged

Conversation

ThibautGeriz
Copy link
Contributor

@ThibautGeriz ThibautGeriz commented Jul 20, 2023

Motivation

Try to reduce the size of the replay payload

Changes

Add experimental flag to disable CSS inlining

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@ThibautGeriz ThibautGeriz requested review from a team as code owners July 20, 2023 16:26
@ThibautGeriz ThibautGeriz marked this pull request as draft July 20, 2023 16:26
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #2348 (ddbdecf) into main (e344f34) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2348      +/-   ##
==========================================
+ Coverage   94.17%   94.19%   +0.01%     
==========================================
  Files         206      206              
  Lines        6134     6135       +1     
  Branches     1358     1358              
==========================================
+ Hits         5777     5779       +2     
+ Misses        357      356       -1     
Impacted Files Coverage Δ
packages/core/src/tools/experimentalFeatures.ts 100.00% <100.00%> (ø)
...domain/record/serialization/serializeAttributes.ts 97.26% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Add experimental flag to disable CSS inlining
@ThibautGeriz ThibautGeriz force-pushed the thibaut.gery/disable-css-inlining-under-experiment-flag branch from 708d5c6 to 8dd527a Compare July 20, 2023 16:34
@ThibautGeriz ThibautGeriz marked this pull request as ready for review July 20, 2023 16:39
@ThibautGeriz ThibautGeriz requested review from bcaudan and a team July 24, 2023 10:22
Co-authored-by: Benoît <benoit.zugmeyer@datadoghq.com>
@ThibautGeriz ThibautGeriz merged commit e15c2fb into main Jul 27, 2023
@ThibautGeriz ThibautGeriz deleted the thibaut.gery/disable-css-inlining-under-experiment-flag branch July 27, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants