-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚗️ [RUM-257] Collect INP #2355
⚗️ [RUM-257] Collect INP #2355
Conversation
1f903a7
to
698342f
Compare
Codecov Report
@@ Coverage Diff @@
## main #2355 +/- ##
==========================================
- Coverage 93.92% 93.83% -0.09%
==========================================
Files 210 212 +2
Lines 6237 6312 +75
Branches 1386 1405 +19
==========================================
+ Hits 5858 5923 +65
- Misses 379 389 +10
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
packages/rum-core/src/domain/rumEventsCollection/view/trackViewMetrics.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
a973bfe
to
73c2fdc
Compare
73c2fdc
to
2723bb3
Compare
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/interactionCountPolyfill.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/interactionCountPolyfill.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackViewMetrics.ts
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
05d0724
to
1bd912a
Compare
packages/rum-core/src/domain/rumEventsCollection/view/interactionCountPolyfill.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.ts
Show resolved
Hide resolved
if (entry.duration > longestInteractions[interactionIndex].duration) { | ||
longestInteractions[interactionIndex] = entry | ||
sortAndTrimLongestInteractions() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 suggestion: cf codecov, what about adding a test for this code path?
packages/rum-core/src/domain/rumEventsCollection/view/trackInteractionToNextPaint.spec.ts
Outdated
Show resolved
Hide resolved
0a0d5a2
to
85e1a32
Compare
Motivation
Interaction to Next Paint (INP) is a Core Web Vital metric that will replace First Input Delay (FID) in March 2024. INP assesses a page's overall responsiveness to user interactions by observing the latency of all clicks, taps, and keyboard interactions that occur throughout the lifespan of a user's visit to a page
Changes
Collect INP under
view.interaction_to_next_paint
Testing
I have gone over the contributing documentation.