Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ [RUM-257] Collect INP #2355

Merged
merged 20 commits into from
Aug 25, 2023
Merged

⚗️ [RUM-257] Collect INP #2355

merged 20 commits into from
Aug 25, 2023

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Jul 25, 2023

Motivation

Interaction to Next Paint (INP) is a Core Web Vital metric that will replace First Input Delay (FID) in March 2024. INP assesses a page's overall responsiveness to user interactions by observing the latency of all clicks, taps, and keyboard interactions that occur throughout the lifespan of a user's visit to a page

Changes

Collect INP under view.interaction_to_next_paint

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner July 25, 2023 15:43
@amortemousque amortemousque marked this pull request as draft July 25, 2023 15:43
@amortemousque amortemousque changed the title ✨Collect INP ✨[RUM-257] Collect INP Jul 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #2355 (c84c2f9) into main (084db3d) will decrease coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is 86.25%.

@@            Coverage Diff             @@
##             main    #2355      +/-   ##
==========================================
- Coverage   93.92%   93.83%   -0.09%     
==========================================
  Files         210      212       +2     
  Lines        6237     6312      +75     
  Branches     1386     1405      +19     
==========================================
+ Hits         5858     5923      +65     
- Misses        379      389      +10     
Files Changed Coverage Δ
.../domain/rumEventsCollection/view/viewCollection.ts 100.00% <ø> (ø)
...mEventsCollection/view/interactionCountPolyfill.ts 47.05% <47.05%> (ø)
...ages/rum-core/src/browser/performanceCollection.ts 51.51% <60.00%> (-0.53%) ⬇️
packages/core/src/tools/experimentalFeatures.ts 100.00% <100.00%> (ø)
...entsCollection/view/trackInteractionToNextPaint.ts 100.00% <100.00%> (ø)
...omain/rumEventsCollection/view/trackViewMetrics.ts 98.21% <100.00%> (+1.95%) ⬆️
.../src/domain/rumEventsCollection/view/trackViews.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amortemousque amortemousque force-pushed the aymeric/collect-inp branch 3 times, most recently from a973bfe to 73c2fdc Compare July 27, 2023 08:08
@amortemousque amortemousque marked this pull request as ready for review July 27, 2023 08:30
Comment on lines +79 to +82
if (entry.duration > longestInteractions[interactionIndex].duration) {
longestInteractions[interactionIndex] = entry
sortAndTrimLongestInteractions()
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 suggestion: ‏cf codecov, what about adding a test for this code path?

@amortemousque amortemousque changed the title ✨[RUM-257] Collect INP ⚗️ [RUM-257] Collect INP Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants