♻️ [RUM-253] refactor batch creation #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to-staging |
|
🚂 Branch Integration: starting soon, merge in < 8m commit 11a3d7781b will soon be integrated into staging-34. This build is going to start soon! (estimated merge in less than 8m) you can cancel this operation by commenting your pull request with |
|
🚂 Branch Integration: this commit was successfully integrated Commit 11a3d7781b has been merged into staging-34 in merge commit b7b2eb885c. Check out the triggered pipeline on Gitlab 🦊 |
bcaudan
reviewed
Aug 25, 2023
Co-authored-by: Bastien Caudan <1331991+bcaudan@users.noreply.github.com>
amortemousque
approved these changes
Aug 28, 2023
bcaudan
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, we create Batch instances in two places:
startBatchWithReplicaandstartRumBatch. As I'm planning to change how Batch works, in order to avoid repeating myself, this PR factorize the two functions.Changes
startBatchWithReplica(upsert + transform replica message)startBatchWithReplicainstartRumBatchstartBatchWithReplicaTesting
I have gone over the contributing documentation.