🐛 [RUM-89] Do not count discarded resources #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
approved these changes
Sep 4, 2023
bcaudan
approved these changes
Sep 5, 2023
amortemousque
deleted the
aymeric/stop-counting-event-when-resources-not-tracked
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the introduction of
trackResources(cf: PR), resources can now be discarded. They are still sent to the intake for tracing but not indexed in RUM. The discarded resource should not be counted.Changes
Check if the resources is not discarded in
trackEventCounts()Testing
I have gone over the contributing documentation.