-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ [RUM-253] add E2E tests related to compression #2416
Merged
+111
−26
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
import { ExperimentalFeature } from '@datadog/browser-core' | ||
import { createTest, flushEvents } from '../lib/framework' | ||
import { getBrowserName, getPlatformName, withBrowserLogs } from '../lib/helpers/browser' | ||
|
||
describe('transport', () => { | ||
describe('data compression', () => { | ||
createTest('send RUM data compressed') | ||
.withRum({ | ||
enableExperimentalFeatures: [ExperimentalFeature.COMPRESS_BATCH], | ||
}) | ||
.run(async ({ intakeRegistry }) => { | ||
await flushEvents() | ||
|
||
expect(intakeRegistry.rumRequests.length).toBe(2) | ||
|
||
const plainRequest = intakeRegistry.rumRequests.find((request) => request.encoding === null) | ||
const deflateRequest = intakeRegistry.rumRequests.find((request) => request.encoding === 'deflate') | ||
|
||
// The last view update should be sent without compression | ||
expect(plainRequest!.events).toEqual([ | ||
jasmine.objectContaining({ | ||
type: 'view', | ||
}), | ||
]) | ||
|
||
// Other data should be sent encoded | ||
expect(deflateRequest!.events.length).toBeGreaterThan(0) | ||
}) | ||
|
||
// Ignore this test on Safari desktop and Firefox because the Worker actually works even with | ||
// CSP restriction. | ||
// TODO: Remove this condition when upgrading to Safari 15 and Firefox 99 | ||
if (!((getBrowserName() === 'safari' && getPlatformName() === 'macos') || getBrowserName() === 'firefox')) { | ||
createTest("displays a message if the worker can't be started") | ||
.withRum({ | ||
enableExperimentalFeatures: [ExperimentalFeature.COMPRESS_BATCH], | ||
}) | ||
.withBasePath('/no-blob-worker-csp') | ||
.run(async ({ intakeRegistry }) => { | ||
await flushEvents() | ||
|
||
// Some non-deflate request can still be sent because on some browsers the Worker fails | ||
// asynchronously | ||
expect(intakeRegistry.rumRequests.filter((request) => request.encoding === 'deflate').length).toBe(0) | ||
|
||
await withBrowserLogs((logs) => { | ||
const failedToStartLog = logs.find((log) => log.message.includes('Datadog RUM failed to start')) | ||
const cspDocLog = logs.find((log) => log.message.includes('Please make sure CSP')) | ||
expect(failedToStartLog).withContext("'Failed to start' log").toBeTruthy() | ||
expect(cspDocLog).withContext("'CSP doc' log").toBeTruthy() | ||
}) | ||
}) | ||
} | ||
}) | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 thought: did you consider bumping them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did, but I decided that it was not the right place to do it, as it might involve more things (everywhere we use
getBrowserName
for skipping tests, we should see if it still makes sense with newer versions)