Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUM-253] enable RUM request compression via the compressIntakeRequests parameter #2500

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Nov 7, 2023

Motivation

Depending on how it is used, the Browser SDK can send a lot of data to the Datadog intake. This PR introduce a new compressIntakeRequests initialization parameter to allow users to opt-in to request compression. Before using it:

  • if you are using the proxy initialization parameter, make sure your that your proxy supports binary payloads, regardless of the Content-Encoding or Content-Type headers

  • if you are using Content-Security-Policy headers, make sure you allow blob workers (see doc)

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner November 7, 2023 16:03
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/compression--init-param branch from 4eb71fc to f898987 Compare November 7, 2023 16:03
@BenoitZugmeyer
Copy link
Member Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Nov 7, 2023

🚂 Branch Integration: starting soon, merge in < 8m

Commit f898987a8b will soon be integrated into staging-45.

This build is going to start soon! (estimated merge in less than 8m)

you can cancel this operation by commenting your pull request with /to-staging -c!

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Nov 7, 2023

🚂 Branch Integration: This commit was successfully integrated

Commit f898987a8b has been merged into staging-45 in merge commit adb0f31c5f.

Check out the triggered pipeline on Gitlab 🦊

@dd-devflow dd-devflow bot added the staging-45 label Nov 7, 2023
@BenoitZugmeyer BenoitZugmeyer changed the title ✨ [RUM-253] enable compression via the compressIntakeRequests parameter ✨ [RUM-253] enable RUM request compression via the compressIntakeRequests parameter Nov 8, 2023
@BenoitZugmeyer BenoitZugmeyer merged commit 89bf1b4 into main Nov 8, 2023
3 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/compression--init-param branch November 8, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants