Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUM-1214] Collect core web vitals target selectors #2506

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented Nov 20, 2023

Motivation

Currently the web vitals are reported with a single value representing the vital score. These scores provide valuable insights to customers, allowing them to determine the performance quality of their website. However, to effectively improve them, it is crucial to identify the specific component to which a vital refers.

Changes

Remove web_vitals_attribution feature flag

image

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner November 20, 2023 08:25
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (279ccd2) 93.24% compared to head (574a6f3) 93.23%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2506      +/-   ##
==========================================
- Coverage   93.24%   93.23%   -0.01%     
==========================================
  Files         222      222              
  Lines        6662     6654       -8     
  Branches     1467     1460       -7     
==========================================
- Hits         6212     6204       -8     
  Misses        450      450              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amortemousque amortemousque merged commit ae88857 into main Nov 20, 2023
2 checks passed
@amortemousque amortemousque deleted the aymeric/enable-web-vital-attribution branch November 20, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants