Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [Logs] reorganise some components #2519

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Dec 1, 2023

Motivation

Housekeeping

Changes

  • Extract various components
  • Regroup telemetry concerns

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan force-pushed the bcaudan/logs-refacto branch from 3f2d667 to 1356fbe Compare December 1, 2023 12:59
@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (603d6a0) 93.22% compared to head (1356fbe) 93.23%.
Report is 1 commits behind head on main.

Files Patch % Lines
packages/logs/src/domain/logsTelemetry.ts 77.27% 5 Missing ⚠️
packages/logs/src/domain/reportError.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2519      +/-   ##
==========================================
+ Coverage   93.22%   93.23%   +0.01%     
==========================================
  Files         222      225       +3     
  Lines        6654     6656       +2     
  Branches     1460     1460              
==========================================
+ Hits         6203     6206       +3     
+ Misses        451      450       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcaudan bcaudan marked this pull request as ready for review December 4, 2023 08:26
@bcaudan bcaudan requested a review from a team as a code owner December 4, 2023 08:27
@bcaudan bcaudan merged commit f611ff5 into main Dec 8, 2023
17 checks passed
@bcaudan bcaudan deleted the bcaudan/logs-refacto branch December 8, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants