✅[e2e] wait for browser url loaded #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try to fix e2e issue: `Unable to get property 'logger' of undefined or null reference` calls to load the page url from the server are not in server.log
BenoitZugmeyer
approved these changes
Feb 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=========================================
- Coverage 86.12% 85.52% -0.6%
=========================================
Files 24 24
Lines 1297 1299 +2
Branches 271 271
=========================================
- Hits 1117 1111 -6
- Misses 180 188 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to fix e2e issue:
Unable to get property 'logger' of undefined or null referencecalls to load the page url from the server are not in server.log