✨[RUM-2436] add partitioned support for third party cookies #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2535 +/- ##
==========================================
- Coverage 92.87% 92.84% -0.03%
==========================================
Files 227 227
Lines 6720 6726 +6
Branches 1476 1480 +4
==========================================
+ Hits 6241 6245 +4
- Misses 479 481 +2 ☔ View full report in Codecov by Sentry. |
bcaudan
force-pushed
the
bcaudan/partitioned-cookies
branch
from
81326db to
7d92fa2
Compare
BenoitZugmeyer
approved these changes
Dec 20, 2023
amortemousque
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
cf #2518, to address the phasing out of third-party cookies by google, introduce a new browser SDK config parameter allowing to configure the session cookie as partitioned.
Changes
with init configuration:
usePartitionedCrossSiteSessionCookie: true_dd_scookie is set withsame-site=none;secure;partitionedTesting
I have gone over the contributing documentation.