♻️ pass the Observable instance to the onFirstSubscribe callback #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change mimics the [TC39 observable proposal][1] (and various implementations) by providing a way to notify directly as a onFirstSubscribe parameter. Contrary to the TC39 proposal and other implementations, it simply provide the observable instance, instead of introducing a new "observer" concept (Observable and Observer concepts are "merged" in our implementation). This is a simple quality of life improvement, but also fixes a typing issue I stumbled upon where TS claimed that the "observable" variable was not necessary defined when it referred to the outer scope variable. [1]: https://github.com/tc39/proposal-observable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2539 +/- ##
==========================================
- Coverage 92.87% 92.82% -0.06%
==========================================
Files 227 227
Lines 6726 6714 -12
Branches 1480 1480
==========================================
- Hits 6247 6232 -15
- Misses 479 482 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a simple quality of life improvement, but also fixes a typing issue I stumbled upon where TS claimed that the "observable" variable was not well defined when it referred to the outer scope variable (see example)
Changes
This change mimics the TC39 observable proposal (and various implementations) by providing a way to notify directly as a onFirstSubscribe parameter.
Contrary to the TC39 proposal and other implementations, it simply provide the observable instance, instead of introducing a new "observer" concept (Observable and Observer concepts are "merged" in our implementation).
Testing
I have gone over the contributing documentation.