-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Browser SDK][RUM-291] Allow logs when cookies are disabled #255
✨ [Browser SDK][RUM-291] Allow logs when cookies are disabled #255
Conversation
… a different RUM and LOGS valid browsing context / do not pass a sessionId when the cookies are off
…n get id return undefined when no cookies at a upper level
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
+ Coverage 85.46% 85.86% +0.39%
==========================================
Files 24 24
Lines 1321 1323 +2
Branches 276 276
==========================================
+ Hits 1129 1136 +7
+ Misses 192 187 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is actually not a bug fix but a new feature, can you rename your PR to something like:
✨ Allow logs when cookies are disabled
…of github.com:DataDog/browser-sdk into maxime.quentin/RUM-291-fix-logs-with-disabled-cookies
What it does
When the cookies are disabled, only the RUM events are blocked. All collected log events will be sent without a session id.
Context
https://datadoghq.atlassian.net/browse/RUMF-291
https://trello.com/c/ttMmQ7vw/70-browser-logs-datadog-browser-agent-doesnt-work-in-an-environment-where-cookies-are-disabled
Client have a native iOS app that opens up a web app in UIWebView that blocks cookies. As a result the
DD_LOGS.logger.log
does not send anything as neither the session id, neither the 'Tracked or not' mode can be read from the cookies.Changes
isValidBrowsingContext
has now two modes for each package that allow the cookies=OFF for logs and block it for rum