-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUM-2729] collect connectivity data #2560
Conversation
34b9945
to
0baba70
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2560 +/- ##
==========================================
+ Coverage 92.84% 92.85% +0.01%
==========================================
Files 228 229 +1
Lines 6719 6731 +12
Branches 1481 1484 +3
==========================================
+ Hits 6238 6250 +12
Misses 481 481 ☔ View full report in Codecov by Sentry. |
/to-staging |
🚂 Branch Integration: starting soon, merge in < 7m Commit 0baba70447 will soon be integrated into staging-02. This build is going to start soon! (estimated merge in less than 7m) you can cancel this operation by commenting your pull request with |
🚂 Branch Integration: This commit was successfully integrated Commit 0baba70447 has been merged into staging-02 in merge commit 0682e6189d. Check out the triggered pipeline on Gitlab 🦊 |
0baba70
to
5cd13bb
Compare
Hey, @bcaudan, I was looking for someone using Network Information API and found out Datadog was doing something similar to what I'm working on. Your approach was quite the same as mine, except that I'm having trouble to access |
Hi @tarsojabbes, Looking at the spec, there is no |
Super thanks for your feedback! My bad, when I said |
Motivation
Collect connectivity data to provide more context on end user environment.
Changes
Collect when available:
connected
|not_connected
bluetooth
|wifi
| ...2g
|3g
| ...Testing
I have gone over the contributing documentation.